qa-test-review
Test code review for test files only: conventions, isolation, object-model patterns, framework architecture audits, and test suite health checks. Includes a framework blueprint for new suites and a test design scorecard. Agents (test-code-critic, e2e-selector-quality-critic, framework-architecture-auditor, test-suite-health-auditor) review structure, assertions and mocking, selector fragility, framework architecture, and suite health. Production code is out of scope.
Install this plugin
View source (opens in a new tab)/plugin install qa-test-review@testland-qaFirst time? Add the marketplace with /plugin marketplace add testland/qa
Plugin
- Category
- Foundations
- Version
v1.8.8- Contents
- 7 skills · 4 agents
Skills7
object-model-patternsUse when designing, reviewing or migrating a test framework's object model: Page Object, Screenplay, Component Object, App Actions, Service Object, Repository and Screen Object for desktop and mobile.skilltest-code-conventionsPure-reference catalog of test-code conventions: AAA structure (Arrange / Act / Assert), per-test single-responsibility, descriptive naming ({sut}_{scenario}_{expected}), assertion specificity, mocking rationale (state vs behavior, fake vs mock), fixture-coupling rules, the magic-number / hard-coded-string anti-patterns, and step design (§11: FIRST principles, step granularity, the mechanical → page → business abstraction layers, the rule-of-three extraction heuristic, declarative phrasing); the E2E selector-priority, web-first-assertion, and step-grouping conventions live in references/.skilltest-design-scorecardUse when a test diff needs a graded coaching review rather than a merge verdict: onboarding a new engineer, ramping up test discipline, or a quarterly per-author trend.skilltest-framework-architecture-auditUse when a test automation framework has grown without structural review, before a big refactor, or when its written conventions may no longer match the code.skilltest-framework-blueprintUse when designing a test automation framework from scratch or re-architecting one that grew organically.skilltest-isolation-patternsPure reference catalog of test-isolation and fixture-lifecycle patterns - the four-phase test pattern (Meszaros), fixture scope (per-test / per-describe / shared / global), the Fresh-Fixture vs Shared-Fixture trade-off (Fowler), parallel-safety patterns, and cleanup discipline (afterEach / afterAll / tagged-cleanup), plus a pattern-selection guide and a worked leaking-state diagnosis.skilltest-suite-health-auditUse when a test suite has grown for a year or more without review and someone needs to know if it is healthy before deleting or rewriting tests.skill
Agents4
e2e-selector-quality-criticAdversarial reviewer specialized for E2E test selector fragility only - flags brittle CSS class selectors / nth-child / XPath / position-based selectors and recommends getByRole / getByLabelText / accessibility-first equivalents per Testing Library's priority order.agentframework-architecture-auditorAdversarial reviewer that audits the test framework codebase at the **architecture tier** - POM consistency across pages, base-class hierarchy depth, fixture coupling and scope, helper sprawl, naming-convention drift between modules, retry / wait convention consistency, documented-vs-actual convention drift, CI integration health, and dead helpers.agenttest-code-criticAdversarial reviewer specialized for **test files only** - flags violations of the conventions in test-code-conventions across three dimensions: structure (AAA, single-responsibility per test, descriptive naming, magic numbers, fixture coupling, slow setup - §1-§3, §6, §7, §10), assertion quality (wide-vague .toBeTruthy() / .toBeDefined() matchers, narrow-vague bounds where the exact value is known, unanchored .toContain('error') - §4), and mocking (over-mocking, behavior-verification leakage, mock chains, mocking third-party boundaries the team doesn't own - §5), with file:line evidence and the convention-section reference.agenttest-suite-health-auditorAdversarial cross-tool auditor that evaluates an existing test suite's current state across seven axes: file inventory, tier classification (unit/integration/E2E), pyramid ratio vs canonical 70/20/10, per-layer flake rate, ROI per tier, selector quality, and assertion quality.agent
About qa-test-review
Test code quality reviewers - agents specialized for test files only, not production code. Production-code reviewers are well-served by the broader ecosystem; test-code hygiene (AAA structure, assertion specificity, mocking anti-patterns, E2E selector quality) is its own discipline and gets its own reviewers here.